linux-kernel - Re: [PATCH v2] checkpatch: update $logFunctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1484537711.2835.10.camel@perches.com>
Date:   Sun, 15 Jan 2017 19:35:11 -0800
From:   Joe Perches <joe@...ches.com>
To:     miles.chen@...iatek.com, Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, wsd_upstream@...iatek.com
Subject: Re: [PATCH v2] checkpatch: update $logFunctions

On Mon, 2017-01-16 at 11:25 +0800, miles.chen@...iatek.com wrote:
> From: Miles Chen <miles.chen@...iatek.com>
> 
> Currently checkpatch.pl does not recognize printk_deferred* functions as
> log functions and complains about the line length of printk_deferred*
> functoins.  Add printk_deferred* to logFunctions to fix it.

Thanks Miles.

s/functoins/functions/

Andrew, if you apply this, could you please correct
the spello above?  

> Signed-off-by: Miles Chen <miles.chen@...iatek.com>

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..36e5932 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -424,7 +424,7 @@ our $typeTypedefs = qr{(?x:
>  our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
>  
>  our $logFunctions = qr{(?x:
> -	printk(?:_ratelimited|_once|)|
> +	printk(?:_ratelimited|_once|_deferred_once|_deferred|)|
>  	(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
>  	WARN(?:_RATELIMIT|_ONCE|)|
>  	panic|