lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 16 Jan 2017 13:49:10 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     aduyck@...antis.com, jiri@...lanox.com, tom@...bertland.com,
        edumazet@...gle.com, hadarh@...lanox.com,
        simon.horman@...ronome.com, fgao@...ai8.com, amir@...ai.me,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] flow dissector: check if arp_eth is null rather
 than arp

From: Colin King <colin.king@...onical.com>
Date: Fri, 13 Jan 2017 18:48:20 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> arp is being checked instead of arp_eth to see if the call to
> __skb_header_pointer failed. Fix this by checking arp_eth is
> null instead of arp.   Also fix to use length hlen rather than
> hlen - sizeof(_arp); thanks to Eric Dumazet for spotting
> this latter issue.
> 
> CoverityScan CID#1396428 ("Logically dead code") on 2nd
> arp comparison (which should be arp_eth instead).
> 
> Fixes: commit 55733350e5e8b70c5 ("flow disector: ARP support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.

Powered by blists - more mailing lists