linux-kernel - Re: [PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170116213551.GK16017@joana>
Date:   Mon, 16 Jan 2017 19:35:51 -0200
From:   Gustavo Padovan <gustavo@...ovan.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Rongrong Zou <zourongrong@...il.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Chen Feng <puck.chen@...ilicon.com>,
        David Airlie <airlied@...ux.ie>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to
 PTR_ERR()

Hi Wei,

2017-01-12 Wei Yongjun <weiyj.lk@...il.com>:

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> PTR_ERR should access the value just tested by IS_ERR, otherwise
> the wrong error code will be returned.
> 
> Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.com>

Gustavo