linux-kernel - Re: [PATCH] staging: fsl-mc: fix coding stye errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170117082708.GC4051@mwanda>
Date:   Tue, 17 Jan 2017 11:27:09 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Dhananjay Balan <dhananjay@...qz.com>
Cc:     Stuart Yoder <stuart.yoder@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fsl-mc: fix coding stye errors

On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> Split line at boolean operator.
> 
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
> 
> Signed-off-by: Dhananjay Balan <dhananjay@...qz.com>
> ---
>  drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> index 6b1cd57..6b19a21 100644
> --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
> @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void)
>  			continue;
>  		}
>  
> -		WARN_ON(mc_msi_domain->
> -				host_data != &its_fsl_mc_msi_domain_info);
> +		WARN_ON(mc_msi_domain->host_data !=
> +						&its_fsl_mc_msi_domain_info);

Better to line it up like this:

		WARN_ON(mc_msi_domain->host_data !=
			&its_fsl_mc_msi_domain_info);

regards,
dan carpenter