lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jan 2017 10:09:56 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: Borislav Petkov <bp@...en8.de> cc: Prarit Bhargava <prarit@...hat.com>, linux-kernel@...r.kernel.org, Tony Luck <tony.luck@...el.com>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, linux-edac@...r.kernel.org Subject: Re: [PATCH] x86/mce: Fix initialization error warning On Tue, 17 Jan 2017, Borislav Petkov wrote: > On Tue, Jan 17, 2017 at 09:34:18AM +0100, Thomas Gleixner wrote: > > That's one thing, but OTOH we really can avoid the KERN_ERR level print out > > for the case where mce is not available (for whatever reasons: HW / Virt / > > command line ....). > > > > The simple 2 liner I posted earlier in this thread does it nicely. > > Well, I seem to remember at the time of this: > > 9c15a24b038f ("x86/mce: Improve mcheck_init_device() error handling") > > that I requested to have that error message there so that we *know* when > that function fails instead of trying to decipher "Hey, mcelog doesn't > start here" and wonder why. > > But we can kill it just as well, especially as there's patch deprecating > /dev/mcelog floating around. We can reorg error messages in that > function later, if deemed necessary. Your decision.
Powered by blists - more mailing lists