linux-kernel - Re: [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170117112817.GD32502@pali>
Date:   Tue, 17 Jan 2017 12:28:17 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Michał Kępień <kernel@...pniu.pl>,
        Richard Purdie <rpurdie@...ys.net>,
        Darren Hart <dvhart@...radead.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Anthony Wong <anthony.wong@...onical.com>,
        linux-leds@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] dell-led: move driver to
 drivers/platform/x86/dell-wmi-led.c

On Tuesday 17 January 2017 12:08:09 Pavel Machek wrote:
> Hi!
> 
> > Thanks for the patch set.
> > 
> > Would you mind fixing also the following issues raised by
> > checkpatch.pl?:
> > 
> > WARNING: Missing a blank line after declarations
> > #376: FILE: drivers/platform/x86/dell-wmi-led.c:64:
> > +	struct bios_args args;
> ...
> > The fixes could be placed in an incremental patch after this one.
> 
> Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.)
> 
> Thanks,
> 
> Acked-by: Pavel Machek <pavel@....cz>

Yes, this patch does not change code, just move one file to other
location. You can add my Reviewed-by.

-- 
Pali Rohár
pali.rohar@...il.com