linux-kernel - Re: [PATCH v1 00/54] block: support multipage bvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPW4GFDy+vXfO+nksTYDoGAmedzP5cN88f_uC-TJp6MAg@mail.gmail.com>
Date:   Tue, 17 Jan 2017 10:40:36 +0800
From:   Ming Lei <tom.leiming@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jens Axboe <axboe@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-block <linux-block@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: [PATCH v1 00/54] block: support multipage bvec

On Mon, Jan 16, 2017 at 11:18 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Mon, Jan 16, 2017 at 11:19:19AM +0800, Ming Lei wrote:
>> Any comments on this version?
>
> We'll need to make sure all drivers can handle multi-page bvecs
> before continuing any other work.  Without that the series is a no-go.
> Note that in general making a drivers capable of handling multipage
> bvecs will clean it up by using new helpers and be worthwhile on it's
> own.

IMO, the only one left is raid(1/5/10) which can be dealt with by the
"NO_MP" flag. This point can be observed by result from runnig 'git grep':

          $git grep -n -E "bi_vcnt|bi_io_vec" ./

Also this patchset addes comment in cases of direct access to bvec table,
and the cases have been minimized too, and most of them are single
bvec based.


Thanks,
Ming Lei