linux-kernel - Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jan 2017 15:40:04 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device

On Mon, 2017-01-16 at 22:00 +0100, Thomas Gleixner wrote:

> The early callback does not work, but we have one which is invoked
> later
> on: x86_init.wallclock_init(). That's invoked after the (IO/APIC)
> setup has
> been completed. See patch below.

Unfortunately it is till too early. Looks like descriptors are not
available yet and we still can't get an allocation:

[    0.000000] intel_mid: Failed to allocate RTC interrupt. Disabling
RTC

...

[    0.000000] NR_IRQS:4352 nr_irqs:512 0

> +static void __init intel_mid_legacy_rtc_init(void)
> +{
> +	struct irq_alloc_info info;
> +
> +	ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0);
> +	if (mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info)) {
> +		pr_info("Failed to allocate RTC interrupt. Disabling
> RTC\n");
> +		x86_platform.legacy.rtc = 0;
> +	}
> +}
> +
>  static void intel_mid_arch_setup(void)
>  {
>  	if (boot_cpu_data.x86 != 6) {
> @@ -151,6 +162,10 @@ static void intel_mid_arch_setup(void)
>  	if (intel_mid_ops->arch_setup)
>  		intel_mid_ops->arch_setup();
>  
> +	/* If the platform has an RTC make sure the APIC entry is
> allocated */
> +	if (x86_platform.legacy.rtc)
> +		x86_init.timers.wallclock_init =
> intel_mid_legacy_rtc_init;

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy