linux-kernel - Re: [PATCH v4 3/4] sparc64: Add support for ADI register fields, ASIs and traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170116.232359.2135717859694837287.davem@davemloft.net>
Date:   Mon, 16 Jan 2017 23:23:59 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     khalid.aziz@...cle.com
Cc:     chris.hyser@...cle.com, sowmini.varadhan@...cle.com,
        tushar.n.dave@...cle.com, akpm@...ux-foundation.org,
        nitin.m.gupta@...cle.com, gerald.schaefer@...ibm.com,
        hughd@...gle.com, kirill.shutemov@...ux.intel.com,
        adam.buchbinder@...il.com, minchan@...nel.org,
        allen.pais@...cle.com, viro@...iv.linux.org.uk,
        aryabinin@...tuozzo.com, paul.gortmaker@...driver.com,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        khalid@...ehiking.org
Subject: Re: [PATCH v4 3/4] sparc64: Add support for ADI register fields,
 ASIs and traps

From: Khalid Aziz <khalid.aziz@...cle.com>
Date: Wed, 11 Jan 2017 09:12:53 -0700

> +#define SUN4V_MCD_PRECISE				\
> +	ldxa	[%g0] ASI_SCRATCHPAD, %g2;		\
> +	ldx	[%g2 + HV_FAULT_D_ADDR_OFFSET], %g4;	\
> +	ldx	[%g2 + HV_FAULT_D_CTX_OFFSET], %g5;	\
> +	ba,pt	%xcc, etrap;				\
> +	rd	%pc, %g7;				\
> +	ba,pt	%xcc, sun4v_mcd_detect_precise;		\
> +	nop;						\
> +	nop;

Always indent instructions which sit in the delay slot of a non-annulled
branch, call, or jmpl by one extra space.  For example:

	ba,pt	%xcc, 1f
	 nop

> +sun4v_mcd_detect_precise:
> +	or	%l4, %g0, %o1
> +	or 	%l5, %g0, %o2
> +	call	sun4v_mem_corrupt_detect_precise
> +	add	%sp, PTREGS_OFF, %o0

Likewise.

Also, just do a normal "mov x, y" instead of the "or x, %g0, y" thing.