lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jan 2017 14:44:22 -0500 From: "Martin K. Petersen" <martin.petersen@...cle.com> To: Christoph Hellwig <hch@....de> Cc: Sreekanth Reddy <sreekanth.reddy@...adcom.com>, James Bottomley <James.Bottomley@...senpartnership.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, David Miller <davem@...emloft.net>, Bart Van Assche <Bart.VanAssche@...disk.com>, Christoph Hellwig <hch@...radead.org>, jbaron@...mai.com, "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>, sagi@...mberg.me, Sathya Prakash <sathya.prakash@...adcom.com>, Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>, Hannes Reinecke <hare@...e.de>, "linux-scsi\@vger.kernel.org" <linux-scsi@...r.kernel.org>, Chaitra Basappa <chaitra.basappa@...adcom.com>, dledford@...hat.com, Ingo Molnar <mingo@...nel.org> Subject: Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands >>>>> "Christoph" == Christoph Hellwig <hch@....de> writes: Christoph> On Tue, Jan 17, 2017 at 07:43:51PM +0530, Sreekanth Reddy wrote: >> [Sreekanth] Just for readability purpose, can use use "if >> (test_bit(0, &sas_device_priv_data->ata_command_pending)" instead of >> "if (sas_device_priv_data->ata_command_pending)". Since while >> setting & clearing the bit we are using atomic bit operations. I >> don't see any issue functionality wise. Christoph> I agree. Also while we're into nitpicking - it would be good Christoph> to give bit 0 of the bitmap a name instead of hardcoding the Christoph> 0. I tweaked the test case. We can name the bit later if more flags are needed (and in that case the ata_command_pending would need to get renamed too). In any case. This issue has taken waaay too long to get resolved so the patch is now queued up in 4.10/scsi-fixes. Thanks everyone! -- Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists