linux-kernel - Re: [PATCH] i2c: busses: constify dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170117232349.GY7403@atomide.com>
Date:   Tue, 17 Jan 2017 15:23:49 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, wsa@...-dreams.de,
        linux-omap@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: busses: constify dev_pm_ops structures

* Bhumika Goyal <bhumirks@...il.com> [170115 02:00]:
> Declare dev_pm_ops structures as const as they are only stored in the pm
> field of a device_driver structure. This field is of type const, so
> dev_pm_ops structures having similar properties can be declared const
> too.
> 
> File size before: drivers/i2c/busses/i2c-omap.o
>    text	   data	    bss	    dec	    hex	filename
>    6814	    584	      0	   7398	   1ce6	drivers/i2c/busses/i2c-omap.o
> 
> File size after: drivers/i2c/busses/i2c-omap.o
>    text	   data	    bss	    dec	    hex	filename
>    7006	    392	      0	   7398	   1ce6	drivers/i2c/busses/i2c-omap.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Acked-by: Tony Lindgren <tony@...mide.com>

> ---
>  drivers/i2c/busses/i2c-omap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index c7da0c4..1ebb5e9 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1504,7 +1504,7 @@ static int omap_i2c_runtime_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static struct dev_pm_ops omap_i2c_pm_ops = {
> +static const struct dev_pm_ops omap_i2c_pm_ops = {
>  	SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
>  			   omap_i2c_runtime_resume, NULL)
>  };
> -- 
> 1.9.1
>