linux-kernel - Re: [PATCH] xfs: fix xfs_mode_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170118205512.GA12985@birch.djwong.org>
Date:   Wed, 18 Jan 2017 12:55:12 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-xfs@...r.kernel.org, Dave Chinner <dchinner@...hat.com>,
        Brian Foster <bfoster@...hat.com>,
        Amir Goldstein <amir73il@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: fix xfs_mode_to_ftype() prototype

On Wed, Jan 18, 2017 at 04:12:58PM +0100, Arnd Bergmann wrote:
> A harmless warning just got introduced:
> 
> fs/xfs/libxfs/xfs_dir2.h:40:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
> 
> Removing the 'const' modifier avoids the warning and has no
> other effect.
> 
> Fixes: 1fc4d33fed12 ("xfs: replace xfs_mode_to_ftype table with switch statement")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.

--D

> ---
>  fs/xfs/libxfs/xfs_dir2.c | 2 +-
>  fs/xfs/libxfs/xfs_dir2.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
> index eb64f3884d3d..2f389d366e93 100644
> --- a/fs/xfs/libxfs/xfs_dir2.c
> +++ b/fs/xfs/libxfs/xfs_dir2.c
> @@ -38,7 +38,7 @@ struct xfs_name xfs_name_dotdot = { (unsigned char *)"..", 2, XFS_DIR3_FT_DIR };
>  /*
>   * Convert inode mode to directory entry filetype
>   */
> -const unsigned char xfs_mode_to_ftype(int mode)
> +unsigned char xfs_mode_to_ftype(int mode)
>  {
>  	switch (mode & S_IFMT) {
>  	case S_IFREG:
> diff --git a/fs/xfs/libxfs/xfs_dir2.h b/fs/xfs/libxfs/xfs_dir2.h
> index d4b77ab37a98..d6e6d9d16f6c 100644
> --- a/fs/xfs/libxfs/xfs_dir2.h
> +++ b/fs/xfs/libxfs/xfs_dir2.h
> @@ -37,7 +37,7 @@ extern struct xfs_name	xfs_name_dotdot;
>  /*
>   * Convert inode mode to directory entry filetype
>   */
> -extern const unsigned char xfs_mode_to_ftype(int mode);
> +extern unsigned char xfs_mode_to_ftype(int mode);
>  
>  /*
>   * directory operations vector for encode/decode routines
> -- 
> 2.9.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html