linux-kernel - Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJCg9wXA8hvo1TDPtyRN+ydMs1_S7yzwggvZAnq1aRgag@mail.gmail.com>
Date:   Wed, 18 Jan 2017 15:26:03 -0600
From:   Rob Herring <robh@...nel.org>
To:     Frédéric Danis <frederic.danis.oss@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Jiri Slaby <jslaby@...e.com>,
        Sebastian Reichel <sre@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "Dr . H . Nikolaus Schaller" <hns@...delico.com>,
        Peter Hurley <peter@...leysoftware.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Loic Poulain <loic.poulain@...el.com>,
        Pavel Machek <pavel@....cz>, NeilBrown <neil@...wn.name>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephen Boyd <stephen.boyd@...aro.org>
Subject: Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices

On Wed, Jan 18, 2017 at 5:53 AM, Frédéric Danis
<frederic.danis.oss@...il.com> wrote:
> Hello,
>
> Le 16/01/2017 à 23:54, Rob Herring a écrit :
>>
>> ---
>> v2:
>> - Add modalias sysfs attr and uevent hook
>
> ...
>>
>> +static int serdev_uevent(struct device *dev, struct kobj_uevent_env *env)
>> +{
>> +       /* TODO: ACPI and platform modalias */
>> +       return of_device_uevent_modalias(dev, env);
>> +}
>
> ...
>>
>> +static ssize_t modalias_show(struct device *dev,
>> +                            struct device_attribute *attr, char *buf)
>> +{
>> +       ssize_t len = of_device_get_modalias(dev, buf, PAGE_SIZE - 2);
>> +       buf[len] = '\n';
>> +       buf[len+1] = 0;
>> +       return len+1;
>> +}
>
>
> This prevents from building serdev as a module with following errors:
>   ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko]
> undefined!
>   ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!

Turns out, there's a fix already[1] that should be going in via Greg's tree.

Rob

[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1299121.html