linux-kernel - Re: [PATCH] pinctrl: remove redundant pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYk=LSKzzQuVfLSsoxPtoOy5tHqFZ-gce_CUXjqOiawKQ@mail.gmail.com>
Date:   Wed, 18 Jan 2017 10:24:52 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Lokesh Vutla <lokeshvutla@...com>,
        Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int

On Fri, Jan 13, 2017 at 2:20 PM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redudant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Fixed up speling & commit topic and applied with
Nishanth's ACK!

Yours,
Linus Walleij