linux-kernel - Re: [PATCH V3] x86: call smp vmxoff in smp stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b0c16d2-b271-1aa6-f16a-0f5860397804@redhat.com>
Date:   Wed, 18 Jan 2017 10:30:03 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Xishi Qiu <qiuxishi@...wei.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        wanpeng.li@...mail.com, Andrew Morton <akpm@...ux-foundation.org>,
        hidehiro.kawai.ez@...achi.com, LKML <linux-kernel@...r.kernel.org>,
        Fengtiantian <fengtiantian@...wei.com>,
        Xiexiuqi <xiexiuqi@...wei.com>
Subject: Re: [PATCH V3] x86: call smp vmxoff in smp stop



On 18/01/2017 03:19, Xishi Qiu wrote:
> On 2017/1/17 23:18, Paolo Bonzini wrote:
> 
>>
>>
>> On 14/01/2017 02:42, Xishi Qiu wrote:
>>> From: Tiantian Feng <fengtiantian@...wei.com>
>>>
>>> We need to disable VMX on all CPUs before stop cpu when OS panic,
>>> otherwisewe risk hanging up the machine, because the CPU ignore INIT
>>> signals when VMX is enabled. In kernel mainline this issue existence.
>>>
>>> Signed-off-by: Tiantian Feng <fengtiantian@...wei.com>
>>
>> Xishi,
>>
>> it's still missing your Signed-off-by.
>>
> 
> Hi Paolo,
> 
> This patch is from fengtiantian, and I just send it for him,
> so still should add my SOB?

Yes, both of them should be there.  The "signed-off-by" is a sequence of
all people that managed the patch---so that would be Tiantian first,
then you, then an x86 maintainer.

Paolo

> Thanks,
> Xishi Qiu
> 
>> Paolo
>>
>>> ---
>>>  arch/x86/kernel/smp.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
>>> index 68f8cc2..b574d55 100644
>>> --- a/arch/x86/kernel/smp.c
>>> +++ b/arch/x86/kernel/smp.c
>>> @@ -33,6 +33,7 @@
>>>  #include <asm/mce.h>
>>>  #include <asm/trace/irq_vectors.h>
>>>  #include <asm/kexec.h>
>>> +#include <asm/virtext.h>
>>>  
>>>  /*
>>>   *	Some notes on x86 processor bugs affecting SMP operation:
>>> @@ -162,6 +163,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>>>  	if (raw_smp_processor_id() == atomic_read(&stopping_cpu))
>>>  		return NMI_HANDLED;
>>>  
>>> +	cpu_emergency_vmxoff();
>>>  	stop_this_cpu(NULL);
>>>  
>>>  	return NMI_HANDLED;
>>> @@ -174,6 +176,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>>>  asmlinkage __visible void smp_reboot_interrupt(void)
>>>  {
>>>  	ipi_entering_ack_irq();
>>> +	cpu_emergency_vmxoff();
>>>  	stop_this_cpu(NULL);
>>>  	irq_exit();
>>>  }
>>>
>>
>> .
>>
> 
> 
>