linux-kernel - Re: [PATCH 1/5] perf, tools: Add probing for xed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170118111654.GA8813@krava>
Date:   Wed, 18 Jan 2017 12:16:54 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed

On Thu, Jan 12, 2017 at 09:39:37AM -0800, Andi Kleen wrote:
> On Thu, Jan 12, 2017 at 09:52:53AM +0100, Jiri Olsa wrote:
> > On Wed, Jan 11, 2017 at 02:17:56PM -0800, Andi Kleen wrote:
> > > > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > > > > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > > > > --- a/tools/build/Makefile.feature
> > > > > +++ b/tools/build/Makefile.feature
> > > > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
> > > > >          lzma                            \
> > > > >          get_cpuid                       \
> > > > >          bpf                             \
> > > > > -        sdt
> > > > > +	sdt				\
> > > > 
> > > > looks like you forgot to add xed in here? why the '\' ?
> > > 
> > > I removed it, but incompletely.
> > > 
> > > > anyway, please add it in here so it's visible under make VF=1
> > > 
> > > If I add it here then it is shown by default (even without VF=1).
> > > Arnaldo requested earlier that it shouldn't be shown.
> > 
> > if you put it to FEATURE_TESTS_BASIC then it's displayed only for VF=1
> 
> It's already in FEATURE_TESTS_BASIC:
> 
> @ -63,7 +63,8 @@ FEATURE_TESTS_BASIC :=                  \
>          lzma                            \
>          get_cpuid                       \
>          bpf                             \
> -        sdt
> +       sdt                             \
> +       xed

I see that on FEATURE_TESTS_EXTRA in your xed-4 branch,
unless that's different to what you sent out

jirka