linux-kernel - Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484740467.2133.202.camel@linux.intel.com>
Date:   Wed, 18 Jan 2017 13:54:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device

On Wed, 2017-01-18 at 12:02 +0100, Thomas Gleixner wrote:
> On Wed, 18 Jan 2017, Andy Shevchenko wrote:
> > On Wed, 2017-01-18 at 11:24 +0100, Thomas Gleixner wrote:
> > > Looking deeper it's actually simple. MID already overloads the
> > > timer_init()
> > > setup function. So we can just do it there.
> > 
> > Yes, it does. However I have another solution, just would like to
> > discuss.
> > 
> > There is a timekeeping_init() call, which is a first user of the
> > RTC.
> > I have 3 changes:
> > - introduce arch_pre_timekeeping_init() and move wallclock_init()
> > call
> > there
> 
> Oh no, please don't add yet another arch hook just because we can.

I see.

> > - use almost your initial suggestion
> > - move wallclock_init() to x86_platform and rename to
> > init_wallclock()
> > to be consistent with the rest of wallclock API (this, though, has
> > item
> > to discuss, i.e. __init use for callbacks)
> > 
> > This would allow to clearly initialize virtual RTC or legacy one at
> > the
> > same know point.
> 
> What's wrong with setting up the rtc interrupt in that existing mid
> function? It's a platform quirk and we really do no need yet another
> hook
> to make it look 'generic'. Nothing else than MID uses it.

Nothing specifically wrong. I would give a try to this and send a patch
if everything okay.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy