linux-kernel - Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170118115648.GA7336@krava>
Date:   Wed, 18 Jan 2017 12:56:48 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        mingo@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents

On Mon, Jan 09, 2017 at 05:10:05PM -0800, Andi Kleen wrote:
> > >  	for (f = fields; f->field; f++)
> > >  		if (json_streq(map, field, f->field) && nz) {
> > > +			/* Handle all variations of 0 encounted in JSON */
> > > +			if (json_streq(map, val, "0x00") ||
> > > +			     json_streq(map, val, "0x0"))
> > > +				return 1;
> > 
> > how is this related to the patch? also shouldn't it return 0 ?
> 
> I removed it now. It avoids some extra umask=0x0 entries, but these
> don't hurt.

ack on the version in the branch, but you haven't posted that one

jirka