linux-kernel - Re: [PATCH] staging: fbtft: replace decimal with 4-digit octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VesumWcqqjKk-3PR=Dv-q0Fe+WscXkpkPpG9_G9hA3zJA@mail.gmail.com>
Date:   Wed, 18 Jan 2017 03:16:25 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Stefano Manni <stefano.manni@...il.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: fbtft: replace decimal with 4-digit octal permissions

On Wed, Jan 18, 2017 at 1:38 AM, Stefano Manni <stefano.manni@...il.com> wrote:
> Following error detected by checkpatch.pl:
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
>
> Signed-off-by: Stefano Manni <stefano.manni@...il.com>
> ---
>  drivers/staging/fbtft/flexfb.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
> index ded1071..7d2ffbb 100644
> --- a/drivers/staging/fbtft/flexfb.c
> +++ b/drivers/staging/fbtft/flexfb.c
> @@ -27,40 +27,40 @@
>  #define DRVNAME            "flexfb"
>
>  static char *chip;
> -module_param(chip, charp, 0);
> +module_param(chip, charp, 0000);
>  MODULE_PARM_DESC(chip, "LCD controller");

Perhaps make them readable back?
0400

-- 
With Best Regards,
Andy Shevchenko