linux-kernel - Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc58dd17-a46a-e7ff-7ad4-5c3539ffaf93@arm.com>
Date:   Wed, 18 Jan 2017 13:25:37 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Robin Murphy <robin.murphy@....com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        Tony Lindgren <tony@...mide.com>, arm@...nel.org,
        Magnus Damm <magnus.damm@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Chen-Yu Tsai <wens@...e.org>, Kukjin Kim <kgene@...nel.org>,
        Tsahee Zidenberg <tsahee@...apurnalabs.com>,
        Jason Cooper <jason@...edaemon.net>,
        Simon Horman <horms@...ge.net.au>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Rob Herring <robh+dt@...nel.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC

On 18/01/17 11:57, Robin Murphy wrote:
> On 18/01/17 10:53, Marc Zyngier wrote:
>> Since everybody copied my own mistake from the DT binding example,
>> let's address all the offenders in one swift go.
>>
>> Most of them got the CPU interface size wrong (4kB, while it should
>> be 8kB), except for both keystone platforms which got the control
>> interface wrong (4kB instead of 8kB).
>>
>> In the couple of cases were I knew for sure what implementation
> 
>                          where
> 
>> was used, I've added the "arm,gic-400" compatible string. I'm 99%
>> sure that this is what everyong is using, but short of having the
> 
>                          everyone
> 
>> TRM for all the other SoCs, I've let them alone.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
>> ---
> [...]
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index 63c7cf0..07bf300 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -45,7 +45,7 @@
>>  		interrupt-controller;
>>  		reg = <0x0 0x02561000 0x0 0x1000>,
>>  		      <0x0 0x02562000 0x0 0x2000>,
>> -		      <0x0 0x02564000 0x0 0x1000>,
>> +		      <0x0 0x02564000 0x0 0x2000>,
>>  		      <0x0 0x02566000 0x0 0x2000>;
>>  		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) |
>>  				IRQ_TYPE_LEVEL_HIGH)>;
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index 02708ba..aaff6816 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -35,7 +35,7 @@
>>  		interrupt-controller;
>>  		reg = <0x0 0x02561000 0x0 0x1000>,
>>  		      <0x0 0x02562000 0x0 0x2000>,
>> -		      <0x0 0x02564000 0x0 0x1000>,
>> +		      <0x0 0x02564000 0x0 0x2000>,
>>  		      <0x0 0x02566000 0x0 0x2000>;
>>  		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) |
>>  				IRQ_TYPE_LEVEL_HIGH)>;
> 
> FWIW I happen to have some public Keystone TRMs handy from my DMA offset
> investigations, and both K2G and K2H explicitly say it's a GIC-400 too.

Ah, brilliant. I'll update the patch accordingly.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...