linux-kernel - Re: [PATCH] softingcs: ret is never non-zero, so remove non-zero check and -ENODEV return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <315e8833-1222-88bd-c806-e3688a37dab3@pengutronix.de>
Date:   Wed, 18 Jan 2017 15:44:53 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Colin King <colin.king@...onical.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] softingcs: ret is never non-zero, so remove non-zero
 check and -ENODEV return

On 01/11/2017 04:02 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The error return ret is never zero in the error handling path in
> softingcs_probe, so the check for non-zero and returning -ENODEV
> is logically dead code and hence redundant.  Remove it and just
> return ret.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied to can-next.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)