linux-kernel - Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170118161810.GA14550@krava>
Date:   Wed, 18 Jan 2017 17:18:10 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias
 string

On Wed, Jan 18, 2017 at 07:45:09AM -0800, Andi Kleen wrote:
> On Wed, Jan 18, 2017 at 01:16:06PM +0100, Jiri Olsa wrote:
> > On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > > index 4bfc98953aba..e0c43698fd62 100644
> > > --- a/tools/perf/util/pmu.c
> > > +++ b/tools/perf/util/pmu.c
> > > @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> > >  		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> > >  	}
> > >  	alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
> > > +	alias->str = strdup(val);
> > 
> > where's this one released?
> 
> Aliases are never released AFAIK?

ok, I misplaced that one with the one from sevent struct.. sry

jirka