linux-kernel - Re: [PATCH 2/2] perf diff: Fix -o/--order option behavior (again)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170118182632.GC19212@krava>
Date:   Wed, 18 Jan 2017 19:26:32 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf diff: Fix -o/--order option behavior (again)

On Wed, Jan 18, 2017 at 02:14:57PM +0900, Namhyung Kim wrote:
> The commit 21e6d8428664 changed list_add() to
> perf_hpp__register_sort_field().  However this resulted in a behavior
> change since the field was added to the tail instead of the head.  So
> the -o option is mostly ignored due to its order in the list.
> 
> This patch fixes it by adding perf_hpp__prepend_sort_field().
> 
> Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface")
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka