linux-kernel - Re: [PATCH 04/33] Input: cros_ec_keyb - Drop unnecessary call to dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 10:39:02 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Vic Yang <victoryang@...gle.com>
Subject: Re: [PATCH 04/33] Input: cros_ec_keyb - Drop unnecessary call to
 dev_set_drvdata and other changes

On Wed, Jan 18, 2017 at 09:46:25AM -0800, Guenter Roeck wrote:
> There is no call to platform_get_drvdata() or dev_get_drvdata().
> Drop the unnecessary call to dev_set_drvdata().
> Other relevant changes:
>   Use existing variable 'dev' instead of dereferencing it several times
> 
> This conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Drop dev_set_drvdata()
> - Use local variable 'struct device *dev' consistently
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied, thank you.

> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 25943e9bc8bf..87d071ae21da 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -222,7 +222,7 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
>  	struct device_node *np;
>  	int err;
>  
> -	np = pdev->dev.of_node;
> +	np = dev->of_node;
>  	if (!np)
>  		return -ENODEV;
>  
> @@ -248,7 +248,6 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
>  	ckdev->ec = ec;
>  	ckdev->notifier.notifier_call = cros_ec_keyb_work;
>  	ckdev->dev = dev;
> -	dev_set_drvdata(dev, ckdev);
>  
>  	idev->name = CROS_EC_DEV_NAME;
>  	idev->phys = ec->phys_name;
> -- 
> 2.7.4
> 

-- 
Dmitry