linux-kernel - Re: [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd_xMLHWr6i_w6XWLM3=imgmJNSe_e4QzZbbZ8ixrmBQg@mail.gmail.com>
Date:   Wed, 18 Jan 2017 21:01:44 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol

On Wed, Jan 18, 2017 at 10:13 AM, Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
> The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform
> device for controlling LID" from Nov 25, 2016, leads to the following
> static checker warning:
>
>         drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device()
>         error: uninitialized symbol 'ts_adev'.
>

Pushed to fixes, thanks!

> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
>
> Hi Dan,
>
> Sorry for the lag in treating this simple defect.
>
> Cheers,
> Benjamin
>
>  drivers/platform/x86/surface3-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c
> index cbf4d83..676cfca 100644
> --- a/drivers/platform/x86/surface3-wmi.c
> +++ b/drivers/platform/x86/surface3-wmi.c
> @@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle,
>
>  static int s3_wmi_check_platform_device(struct device *dev, void *data)
>  {
> -       struct acpi_device *adev, *ts_adev;
> +       struct acpi_device *adev, *ts_adev = NULL;
>         acpi_handle handle;
>         acpi_status status;
>
> --
> 2.9.3
>



-- 
With Best Regards,
Andy Shevchenko