linux-kernel - Re: [PATCH] net: ethernet: stmmac: add ARP management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701181026.r6U7Rcvz%fengguang.wu@intel.com>
Date:   Wed, 18 Jan 2017 10:51:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Christophe Roullier <christophe.roullier@...com>
Cc:     kbuild-all@...org, Alexandre Torgue <alexandre.torgue@...com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christophe Roullier <christophe.roullier@...com>
Subject: Re: [PATCH] net: ethernet: stmmac: add ARP management

Hi Christophe,

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20170117]
[cannot apply to v4.10-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Christophe-Roullier/net-ethernet-stmmac-add-ARP-management/20170118-084026
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3296:11: warning: passing argument 3 of 'priv->hw->dma->set_arp_addr' makes integer from pointer without a cast [-Wint-conversion]
              priv->dev->dev_addr);
              ^~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3296:11: note: expected 'u32 {aka unsigned int}' but argument is of type 'unsigned char *'

vim +3296 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

  3280				    NETIF_F_RXCSUM;
  3281	
  3282		if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) {
  3283			ndev->hw_features |= NETIF_F_TSO;
  3284			priv->tso = true;
  3285			dev_info(priv->device, "TSO feature enabled\n");
  3286		}
  3287	
  3288		if ((priv->plat->arp_en) && (priv->dma_cap.arpoffsel)) {
  3289			ret = priv->hw->mac->arp_en(priv->hw);
  3290			if (!ret) {
  3291				pr_warn(" ARP feature disabled\n");
  3292			} else {
  3293				pr_info(" ARP feature enabled\n");
  3294				/* Copy MAC addr into MAC_ARP_ADDRESS register*/
  3295				priv->hw->dma->set_arp_addr(priv->ioaddr, 1,
> 3296							    priv->dev->dev_addr);
  3297			}
  3298		}
  3299	
  3300		ndev->features |= ndev->hw_features | NETIF_F_HIGHDMA;
  3301		ndev->watchdog_timeo = msecs_to_jiffies(watchdog);
  3302	#ifdef STMMAC_VLAN_TAG_USED
  3303		/* Both mac100 and gmac support receive VLAN tag detection */
  3304		ndev->features |= NETIF_F_HW_VLAN_CTAG_RX;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24430 bytes)