linux-kernel - Re: [PATCH 27/33] Input: eeti_ts - Drop unnecessary error messages and other changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170118192644.GD33920@dtor-ws>
Date:   Wed, 18 Jan 2017 11:26:44 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 27/33] Input: eeti_ts - Drop unnecessary error messages
 and other changes

On Wed, Jan 18, 2017 at 09:46:48AM -0800, Guenter Roeck wrote:
> Error messages after memory allocation failures are unnecessary and
> can be dropped.
> 
> This conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Drop unnecessary braces around conditional return statements
> - Drop error message after devm_kzalloc() failure
> - Replace 'goto l; ... l: return e;' with 'return e;'

Kept just the last part and applied, thank you.

> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/input/touchscreen/eeti_ts.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
> index 09be6ced7151..de3f4a1e8416 100644
> --- a/drivers/input/touchscreen/eeti_ts.c
> +++ b/drivers/input/touchscreen/eeti_ts.c
> @@ -171,10 +171,8 @@ static int eeti_ts_probe(struct i2c_client *client,
>  	 */
>  
>  	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> -	if (!priv) {
> -		dev_err(&client->dev, "failed to allocate driver data\n");
> -		goto err0;
> -	}
> +	if (!priv)
> +		return err;
>  
>  	mutex_init(&priv->mutex);
>  	input = input_allocate_device();
> @@ -243,7 +241,6 @@ static int eeti_ts_probe(struct i2c_client *client,
>  err1:
>  	input_free_device(input);
>  	kfree(priv);
> -err0:
>  	return err;
>  }
>  
> -- 
> 2.7.4
> 

-- 
Dmitry