linux-kernel - Re: [PATCH] lib: sort: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 14:31:13 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kostenzer Felix <fkostenzer@...e.at>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib: sort: make it explicitly non-modular

[Re: [PATCH] lib: sort: make it explicitly non-modular] On 18/01/2017 (Wed 20:03) Andy Shevchenko wrote:

> On Wed, Jan 18, 2017 at 6:20 PM, Paul Gortmaker
> <paul.gortmaker@...driver.com> wrote:
> > The Makefile currently controlling compilation of this code is:
> >
> >      lib/Kconfig.debug:config TEST_SORT
> >      lib/Kconfig.debug:      bool "Array-based sort test"
> >
> > and...
> >
> >      lib/Makefile:obj-y += bcd.o div64.o sort.o [...]
> >
> > ...meaning that it currently is not being built as a module by anyone.
> 
> Perhaps allow it to be a module?

If anything, I'd argue the other way and say we shouldn't be further
polluting Kconfig space with more super specific options.  Instead
something more generic like CONFIG_ENABLE_BOOT_SELF_TESTS that at least
could be shared.

There is no real value in making something a module when it could just
as easily be thrown out as __init code/data.

> 
> Besides that perhaps rename to something like test_sort.c ?

The sort.c was not added just for the test code ; it already existed for
the sort code itself.

Paul.
--



> 
> -- 
> With Best Regards,
> Andy Shevchenko