linux-kernel - Re: [PATCH net-next] macb: Common code to enable ptp support for SAMA5Dx platforms.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2017 09:52:51 +0530
From:   Harini Katakam <harinikatakamlinux@...il.com>
To:     Nicolas Ferre <nicolas.ferre@...el.com>
Cc:     Andrei Pistirica <andrei.pistirica@...rochip.com>,
        netdev@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        David Miller <davem@...emloft.net>,
        Harini Katakam <harini.katakam@...inx.com>,
        Richard Cochran <richardcochran@...il.com>,
        Rafal Ozieblo <rafalo@...ence.com>,
        Punnaiah Choudary Kalluri <punnaia@...inx.com>,
        "michals@...inx.com" <michals@...inx.com>,
        Anirudha Sarangi <anirudh@...inx.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        alexandre.belloni@...e-electrons.com, tbultel@...elsurmer.com
Subject: Re: [PATCH net-next] macb: Common code to enable ptp support for
 SAMA5Dx platforms.

On Wed, Jan 18, 2017 at 11:02 PM, Nicolas Ferre <nicolas.ferre@...el.com> wrote:
> Le 18/01/2017 à 09:57, Andrei Pistirica a écrit :
>> This patch does the following:
>> - add GEM-PTP interface
>> - registers and bitfields for TSU are named according to SAMA5Dx data sheet
>> - PTP support based on platform capability
>
> The $subject will certainly never match reality, sadly "enable ptp
> support for SAMA5Dx platforms". So, you'd better change it.
> (no "." at the end BTW).
>
>> Signed-off-by: Andrei Pistirica <andrei.pistirica@...rochip.com>
>> ---
>> This is just the common code for GEM-PTP support. Code is based on the comments
>> related to the following patch series:
>> - [RFC PATCH net-next v1-to-4 1/2] macb: Add 1588 support in Cadence GEM.
>> - [RFC PATCH net-next v1-to-4 2/2] macb: Enable 1588 support in SAMA5Dx platforms.
>>
>> Note: Patch on net-next: January 18.
>>
>> Rafal/Harini, you can continue the work for GME-GXL.

Thanks Andrei.

<snip>
>
> Otherwise, I'm okay with the rest.
>
> I suggest to people that will keep the ball rolling on this topic to
> take advantage of the chunks of code that Andrei developed with the help
> of Richard and the best practices discussed. I think particularly, if it
> makes sense with HW, about:
> - gem_ptp_do_[rt]xstamp(bp, skb) dereference scheme
> - gem_ptp_adjfine() rationale
> - gem_get_ptp_peer() if needed
>

Sure, will patch on top of this.

Regards,
Harini

> Regards,
> --
> Nicolas Ferre