linux-kernel - [PATCH] VME: add again remove entry point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2017 10:29:29 +0100
From:   Stefano Babic <sbabic@...x.de>
To:     linux-kernel@...r.kernel.org
Cc:     martyn.welch@...labora.co.uk, paul.gortmaker@...driver.com,
        Stefano Babic <sbabic@...x.de>
Subject: [PATCH] VME: add again remove entry point

Commit 050c3d52cc7 dropped the remove
entry point. However, vme_bus_remove()
is called when a VME device is removed
from the bus and not when the bus is removed
and it calls the VME device driver's cleanup
function.
Without this function, the remove() in VME
device driver is never called and VME device
drivers cannot be reloaded again.

Signed-off-by: Stefano Babic <sbabic@...x.de>
---
 drivers/vme/vme.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index d078fad..ae35d7b 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1737,10 +1737,25 @@ static int vme_bus_probe(struct device *dev)
 	return retval;
 }
 
+static int vme_bus_remove(struct device *dev)
+{
+	int retval = -ENODEV;
+	struct vme_driver *driver;
+	struct vme_dev *vdev = dev_to_vme_dev(dev);
+
+	driver = dev->platform_data;
+
+	if (driver->remove != NULL)
+		retval = driver->remove(vdev);
+
+	return retval;
+}
+
 struct bus_type vme_bus_type = {
 	.name = "vme",
 	.match = vme_bus_match,
 	.probe = vme_bus_probe,
+	.remove = vme_bus_remove,
 };
 EXPORT_SYMBOL(vme_bus_type);
 
-- 
2.7.4