linux-kernel - Re: [PATCH 04/11] perf, tools: Support per pmu json aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170119104255.GA31975@krava>
Date:   Thu, 19 Jan 2017 11:42:55 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: Re: [PATCH 04/11] perf, tools: Support per pmu json aliases

On Wed, Jan 18, 2017 at 04:17:35PM -0800, Andi Kleen wrote:
> > > index 8bffe99d8e3f..4bfc98953aba 100644
> > > --- a/tools/perf/util/pmu.c
> > > +++ b/tools/perf/util/pmu.c
> > > @@ -587,14 +587,13 @@ static struct perf_pmu *pmu_lookup(const char *name)
> > >  	if (pmu_format(name, &format))
> > >  		return NULL;
> > >  
> > > -	if (pmu_aliases(name, &aliases))
> > > +	if (pmu_type(name, &type))
> > >  		return NULL;
> > >  
> > > -	pmu_add_cpu_aliases(&aliases, name);
> > > -
> > > -	if (pmu_type(name, &type))
> > > +	if (pmu_aliases(name, &aliases))
> > >  		return NULL;
> > >  
> > > +	pmu_add_cpu_aliases(&aliases, name);
> > 
> > AFAICS you switched the calls.. how does it matter?
> 
> It avoids lots of duplicate messages with -v (and also is more efficient)

cool, please state that in chagelog.. before/after

thanks,
jirka