linux-kernel - Re: [PATCH v2 5/6] x86/fpu: Fix CPUID-less FPU detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170119112355.ddtjqass4x5rxr2d@pd.tnic>
Date:   Thu, 19 Jan 2017 12:23:56 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     X86 ML <x86@...nel.org>,
        One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brian Gerst <brgerst@...il.com>,
        Matthew Whitehead <tedheadster@...il.com>
Subject: Re: [PATCH v2 5/6] x86/fpu: Fix CPUID-less FPU detection

On Wed, Jan 18, 2017 at 11:15:41AM -0800, Andy Lutomirski wrote:
> The old code didn't work at all because it adjusted the current caps
> instead of the forced caps.  Anything it did would be undone later
> during cpu identification.  Fix that and, while we're at it, improve

	CPU

> the logging and don't bother running it if CPUID is available.
> 
> Reported-by: Matthew Whitehead <tedheadster@...il.com>
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

Just two minor typos which can be fixed en-route. Other than that, for
all 6:

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.