linux-kernel - RE: [PATCH 2/3] qed: avoid possible stack overflow in qed_ll2_acquire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR07MB2306B71885EAA9BB808414358D7E0@BL2PR07MB2306.namprd07.prod.outlook.com>
Date:   Thu, 19 Jan 2017 13:13:30 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     "David S. Miller" <davem@...emloft.net>,
        "Amrani, Ram" <Ram.Amrani@...ium.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "Hannes Reinecke" <hare@...e.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dept-Eng Everest Linux L2" <Dept-EngEverestLinuxL2@...ium.com>
Subject: RE: [PATCH 2/3] qed: avoid possible stack overflow in
 qed_ll2_acquire_connection

> 968,23 +968,19 @@ static int qed_ll2_start_ooo(struct qed_dev *cdev,  {
>  	struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
>  	u8 *handle = &hwfn->pf_params.iscsi_pf_params.ll2_ooo_queue_id;
> -	struct qed_ll2_info *ll2_info;
> +	struct qed_ll2_conn ll2_info;

A bit confusing to change the type from qed_ll2_info - > qed_ll2_conn
yet leave the variable named 'll2_info'.
Probably better to have it name `ll2_params' as in:

> @@ -2632,7 +2632,7 @@ static int qed_roce_ll2_start(struct qed_dev *cdev,
> {
>  	struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
>  	struct qed_roce_ll2_info *roce_ll2;
> -	struct qed_ll2_info ll2_params;
> +	struct qed_ll2_conn ll2_params;

But that's nitpicking; You can do this if for some reason you'll need a v2,
or we'll later change it in some semantic patch.

Thanks for taking care of this.

Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com>