linux-kernel - Re: [PATCH] rpmsg: char: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 23:08:58 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rpmsg: char: add CONFIG_NET dependency

On Thu 19 Jan 06:54 PST 2017, Arnd Bergmann wrote:

> Without CONFIG_NET, we get a build failure for the new driver:
> 
> ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!
> 
> This adds a dependency so we don't try to build the broken configuration.
> 
> Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied

Thanks,
Bjorn