linux-kernel - Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170119.113228.175631525740148009.davem@davemloft.net>
Date:   Thu, 19 Jan 2017 11:32:28 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     augustocaringi@...il.com
Cc:     jiri@...lanox.com, idosch@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS

From: Augusto Mecking Caringi <augustocaringi@...il.com>
Date: Thu, 19 Jan 2017 11:00:12 +0000

> When CONFIG_ATM_CLIP is set and CONFIG_PROC_FS is not set, the building
> was failing whith the error:
> 
> net/atm/clip.c: In function ‘atm_clip_exit’:
> net/atm/clip.c:933:27: error: ‘atm_proc_root’ undeclared (first use in
> this function)
> remove_proc_entry("arp", atm_proc_root);
>                            ^
> 
> Fix it by putting the proc cleanup code inside a #ifdef CONFIG_PROC_FS
> block.
> 
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@...il.com>

When CONFIG_PROC_FS is not defined, remove_proc_entry is defined as the
macro:

#define remove_proc_entry(name, parent) do {} while (0)

Therefore it is impossible for atm_proc_root to be referened in any way.

The fallback macro is designed exactly so that ugly ifdefs like the one
you are proposing aren't necessary.

I'm not applyiing this patch, something else is happening in your tree.