linux-kernel - Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfB1nTK1Gx6Z_BrRP-zEfxrtcMoW2zOA1wAJMdUQt_tpg@mail.gmail.com>
Date:   Thu, 19 Jan 2017 18:58:57 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Clemens Gruber <clemens.gruber@...ruber.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-pwm@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Florian Vaussard <florian.vaussard@...g-vd.ch>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization

On Thu, Jan 19, 2017 at 6:52 PM, Clemens Gruber
<clemens.gruber@...ruber.com> wrote:
> On Thu, Jan 19, 2017 at 06:10:08PM +0200, Andy Shevchenko wrote:

>> So, summarize, I prefer (in order of preference from high to low):
>> - enforce default prescaler value based on default period (it's just one
>> line to write a register)
>> - calculate default period based on actual prescaler value
>
> Let's go with this one. I'll spin up a v2 where I calculate the
> period_ns value from the current prescaler value in the probe function.

I'm fine with it. Thanks!

-- 
With Best Regards,
Andy Shevchenko