linux-kernel - Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170118234527.GW27312@n2100.armlinux.org.uk>
Date:   Wed, 18 Jan 2017 23:45:28 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Laura Abbott <labbott@...hat.com>
Cc:     kernel-hardening@...ts.openwall.com, mark.rutland@....com,
        f.fainelli@...il.com, keescook@...omium.org, pawel.moll@....com,
        ard.biesheuvel@...aro.org, will.deacon@....com,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jinbum Park <jinb.park7@...il.com>, vladimir.murzin@....com,
        linux-arm-kernel@...ts.infradead.org, andy.gross@...aro.org,
        arjan@...ux.intel.com, mingo@...nel.org,
        paul.gortmaker@...driver.com, jonathan.austin@....com
Subject: Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA

On Wed, Jan 18, 2017 at 03:38:52PM -0800, Laura Abbott wrote:
> On 01/18/2017 02:36 PM, Russell King - ARM Linux wrote:
> > I don't see why this needs to be in cacheflush.h - it doesn't seem to
> > have anything to do with cache flushing, and placing it in here means
> > that if you change the state of CONFIG_DEBUG_RODATA_TEST, most likely
> > the entire kernel gets rebuilt.  Please put it in a separate header
> > file.
> 
> cacheflush.h seems to be where all the set_memory_* functions have
> ended up. I was just looking at cleaning that up unless someone
> beats me to it.

+1

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.