linux-kernel - Re: [PATCH v2 0/6] Selftests fixes for futex and intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2017 07:42:15 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Shuah Khan <shuah@...nel.org>
Cc:     Darren Hart <dvhart@...ux.intel.com>,
        Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2 0/6] Selftests fixes for futex and intel_pstate

On Thu, Jan 19, 2017 at 10:35:21AM -0700, Shuah Khan wrote:
> On 01/11/2017 08:11 AM, Stafford Horne wrote:
> > This is followup to my previous patch [1] which was a very simple makefile
> > change. After a comment from Darren Hart I updated intel_pstate as well,
> > but noticed a few issues with running intel_pstate. That caused the change
> > to expand a bit.
> > 
> >  - fix build deps for futex test *original*
> >  - update makefile for intel_pstate to be in sync with Bamvor's changes
> >  - update cpupower frequency-info to fix intel_pstate test
> > 
> > For the linux-pm list the change to cpupower might be an issue, but if so
> > it would be nice if they can suggest a better way to get the self test to
> > do what it wants to do.
> > 
> > The series is based on Shuah's kselftest next branch, because that is
> > where Bamvor's latest changes are:
> >  git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
> > 
> > [1] https://lkml.org/lkml/2017/1/5/903
> > 
> > Stafford Horne (6):
> >   selftests/futex: Add stdio used for logging
> >   selftests/futex: Add headers to makefile dependencies
> >   cpupower: Restore format of frequency-info limit
> >   selftests/intel_pstate: Fix warning on loop index overflow
> >   selftests/intel_pstate: Update makefile to match new style
> >   selftests: Add intel_pstate to TARGETS
> > 
> >  tools/power/cpupower/utils/cpufreq-info.c         | 21 ++++++++++++---------
> >  tools/testing/selftests/Makefile                  |  1 +
> >  tools/testing/selftests/futex/functional/Makefile |  5 ++++-
> >  tools/testing/selftests/futex/include/logging.h   |  1 +
> >  tools/testing/selftests/intel_pstate/Makefile     | 13 ++++---------
> >  tools/testing/selftests/intel_pstate/aperf.c      |  2 +-
> >  6 files changed, 23 insertions(+), 20 deletions(-)
> > 
> 
> The series is now in linux-kselftest next for 4.11
> 
> thanks for the fixes.

Thanks,

I see you pulled in the cpupower changes too. We didnt get any reply
even though the maintainers are cc'd. I hope thats no issue, but the
changes seem necessary for maintaining test compatibility.

-Stafford