linux-kernel - Re: [PATCH v11 2/8] power: add power sequence library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170120075239.GC21013@b29397-desktop>
Date:   Fri, 20 Jan 2017 15:52:39 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     rjw@...ysocki.net
Cc:     Peter Chen <peter.chen@....com>, mark.rutland@....com,
        ulf.hansson@...aro.org, heiko@...ech.de, stephen.boyd@...aro.org,
        linux-kernel@...r.kernel.org, gary.bisson@...ndarydevices.com,
        festevam@...il.com, stillcompiling@...il.com, arnd@...db.de,
        dbaryshkov@...il.com, vaibhav.hiremath@...aro.org,
        mka@...omium.org, stern@...land.harvard.edu,
        devicetree@...r.kernel.org, mail@...iej.szmigiero.name,
        pawel.moll@....com, linux-pm@...r.kernel.org,
        s.hauer@...gutronix.de, troy.kisky@...ndarydevices.com,
        robh+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
        hverkuil@...all.nl, oscar@...andei.net, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, sre@...nel.org, broonie@...nel.org,
        p.zabel@...gutronix.de, shawnguo@...nel.org,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v11 2/8] power: add power sequence library

On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote:
> On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote:
> > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote:
> > > We have an well-known problem that the device needs to do some power
> > > sequence before it can be recognized by related host, the typical
> > > example like hard-wired mmc devices and usb devices.
> > > 
> > > This power sequence is hard to be described at device tree and handled by
> > > related host driver, so we have created a common power sequence
> > > library to cover this requirement. The core code has supplied
> > > some common helpers for host driver, and individual power sequence
> > > libraries handle kinds of power sequence for devices. The pwrseq
> > > librares always need to allocate extra instance for compatible
> > > string match.
> > > 
> > > pwrseq_generic is intended for general purpose of power sequence, which
> > > handles gpios and clocks currently, and can cover other controls in
> > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off
> > > if only one power sequence is needed, else call of_pwrseq_on_list
> > > /of_pwrseq_off_list instead (eg, USB hub driver).
> > > 
> > > For new power sequence library, it can add its compatible string
> > > to pwrseq_of_match_table, then the pwrseq core will match it with
> > > DT's, and choose this library at runtime.
> > > 
> > > Signed-off-by: Peter Chen <peter.chen@....com>
> > > Tested-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> > > Tested-by Joshua Clayton <stillcompiling@...il.com>
> > > Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> > > Tested-by: Matthias Kaehlcke <mka@...omium.org>
> > 
> > Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> > Tested on Odroid U3 (reset sequence for LAN9730):
> > Tested-by: Krzysztof Kozlowski <krzk@...nel.org>
> > 
> 
> A nice ping...
> 

Rafael, would you please review it? This series was discussed about
half a year, and many people need it, I hope it can be in v4.11-rc1,
thanks.

-- 

Best Regards,
Peter Chen