linux-kernel - Re: [PATCH 0/6] of_graph_get_remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ziimlca0.wl%kuninori.morimoto.gx@renesas.com>
Date:   Fri, 20 Jan 2017 02:04:21 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Frank Rowand <frowand.list@...il.com>,
        Linux-Kernel <linux-kernel@...r.kernel.org>,
        Linux-DT <devicetree@...r.kernel.org>,
        Laurent <laurent.pinchart@...asonboard.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        David Airlie <airlied@...ux.ie>,
        Sean Paul <seanpaul@...omium.org>,
        Peter Chen <peter.chen@....com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Benoit Parrot <bparrot@...com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 0/6] of_graph_get_remote_endpoint()


Hi Rob

> This looks okay, but I think we need to be improving the graph api at
> a higher level. Each user seems to be doing too much open coding of
> walking of the graph. The user typically just wants the remote node
> parent of a given port and endpoint number. Why does the user walk the
> graph to find the endpoint node, then parse remote-endpoint, then walk
> up parents. We have lots of other graph users and you didn't need to
> update them which means they are already using helpers. Maybe the
> drivers here need to be fixed. omapfb in particular looks like it
> duplicates a bunch of helpers we already have, but maybe we're close
> to removing that driver.

Does your "we need to be improving the graph api at a higher level"
mean I need to re-work this patch ?
Or someone (?) will improve OF-graph, and I need to wait it ?
More direct words, will this patch be accepted ??

You know I'm working for OF-graph base HDMI sound now, and actually,
I have some OF-graph new API which is useful for OF-graph HDMI sound support.
(I don't like open coding, I want to have useful/understandable common api)
This get_remote_endpoint is one of them, and was ready for posting.
So, I will post other OF-graph base patches if OF-graph HDMI sound was ready.