[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86db90e2-a7fc-5868-20e5-13f2393f306b@redhat.com>
Date: Fri, 20 Jan 2017 13:58:33 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Marcelo Tosatti <mtosatti@...hat.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Radim Krcmar <rkrcmar@...hat.com>,
Richard Cochran <richardcochran@...il.com>,
Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [patch 5/5] PTP: add kvm PTP driver
On 20/01/2017 13:20, Marcelo Tosatti wrote:
> + ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING,
> + clock_off_gpa,
> + KVM_CLOCK_PAIRING_WALLCLOCK);
> + if (ret != 0) {
> + pr_err("clock offset hypercall ret %lu\n", ret);
> + spin_unlock(&kvm_ptp_lock);
> + preempt_enable_notrace();
> + return -EOPNOTSUPP;
> + }
> +
Is it worth making this hypercall, or even all of ptp_kvm_get_time_fn, a
pv_ops entry?
But this looks good already, apart from my different preference on
emulate_ptp_sys_offset_mean.
Paolo
Powered by blists - more mailing lists