[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 20 Jan 2017 11:07:15 -0200
From: Marcelo Tosatti <mtosatti@...hat.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
Radim Krcmar <rkrcmar@...hat.com>,
Richard Cochran <richardcochran@...il.com>,
Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross
timestamps infrastructure
On Fri, Jan 20, 2017 at 01:55:27PM +0100, Paolo Bonzini wrote:
>
>
> On 20/01/2017 13:20, Marcelo Tosatti wrote:
> > kernel/time/timekeeping.c | 79 +++++++++++++++++++++++++++++++++++++++
>
> Why not leave this in drivers/ptp/ptp_chardev.c?
timekeeper_lock
> > + if (ptp->info->emulate_ptp_sys_offset_mean) {
> > + err = emulate_ptp_sys_offset(ptp->info, sysoff, arg);
> > + break;
> > + }
>
> I think this should be simply "if (!ptp->info->gettime64)" and,
> likewise, there should be an emulation based getcrosststamp in
> ptp_clock_gettime.
>
> Paolo
gettime64 is called directly via ptp_clock_gettime.
Powered by blists - more mailing lists