linux-kernel - Re: [PATCH v2] mtd: spi-nor: Fix S3AN addressing calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52628ae5-8b58-f704-a513-74092c0dfa3a@gmail.com>
Date:   Fri, 20 Jan 2017 14:48:22 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: Fix S3AN addressing calculation

On 01/20/2017 02:26 PM, Cyrille Pitchen wrote:
> Le 18/01/2017 à 17:40, Ricardo Ribalda Delgado a écrit :
>> The page calculation under spi_nor_s3an_addr_convert() was wrong. On
>> Default Address Mode we need to perform a divide by page_size.
>>
>> Fixes: 61cba34bd6c1 ("mtd: spi-nor: Add support for S3AN spi-nor devices")
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> Reviewed-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
> 
> Marek, any comment on your side?

All good,

Acked-by: Marek Vasut <marek.vasut@...il.com>

>> ---
>>
>> v2: Suggested by Marek Vasut <marek.vasut@...il.com>
>>   -Use more descriptive name for page
>>
>>  drivers/mtd/spi-nor/spi-nor.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 2a643a1bb45e..f5c3ce8ac48b 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -431,11 +431,14 @@ static void spi_nor_unlock_and_unprep(struct spi_nor *nor, enum spi_nor_ops ops)
>>   */
>>  static loff_t spi_nor_s3an_addr_convert(struct spi_nor *nor, unsigned int addr)
>>  {
>> -	unsigned int offset = addr;
>> +	unsigned int offset;
>> +	unsigned int page;
>>  
>> -	offset %= nor->page_size;
>> +	offset = addr % nor->page_size;
>> +	page = addr / nor->page_size;
>> +	page <<= (nor->page_size > 512) ? 10 : 9;
>>  
>> -	return ((addr - offset) << 1) | offset;
>> +	return page | offset;
>>  }
>>  
>>  /*
>>
> 


-- 
Best regards,
Marek Vasut