linux-kernel - Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48a2f141-4275-cb79-aafd-62191d747107@osg.samsung.com>
Date:   Fri, 20 Jan 2017 11:00:38 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org, Inki Dae <inki.dae@...sung.com>,
        Andi Shyti <andi.shyti@...sung.com>,
        Shuah Khan <shuahkh@....samsung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        linux-clk@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        Tomasz Figa <tomasz.figa@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as
 CLK_IS_CRITICAL

Hello Sylwester,

On 01/20/2017 10:55 AM, Sylwester Nawrocki wrote:
> On 01/20/2017 01:32 PM, Sylwester Nawrocki wrote:
>> On 01/20/2017 11:41 AM, Javier Martinez Canillas wrote:
>>> On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL
>>> and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it.
>>>
>>> But Exynos5420 only has the CLK_ACLK_300_GSCL as gsc_pd clk. So just using
>>> this definition from exynos5420.dtsi in Exynos5800 leads to the following:
>> [...]
>>> So until a proper solution based on runtime PM gets merged, mark the clock
>>> as critical to prevent it to be gated.
>>>
>>> Suggested-by: Marek Szyprowski <m.szyprowski@...sung.com>
>>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>> Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> 
> Oops, the $subject patch can be dropped since as Marek just pointed out
> to me the changes introduced by that patch are already included in a patch
> which is already in the v4.10 fixes queue:
> 
> https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=318fa46cc60d37fec1e87dbf03a82aca0f5ce695
> 

Yes, I just answered to Marek in the other thread saying the same.
He did mention the patch could fix the issue but for some reason I
didn't see the CLK_ACLK_300_GSCL in the clocks marked as critical...

Anyways, sorry for the noise.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America