linux-kernel - Re: [patch-rt] softirq: Move ksoftirqd_running() under !CONFIG_PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2017 18:21:09 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Mike Galbraith <efault@....de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rt-users <linux-rt-users@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [patch-rt] softirq: Move ksoftirqd_running() under
 !CONFIG_PREEMPT_RT_FULL

On 2016-12-31 09:20:10 [+0100], Mike Galbraith wrote:
> 
> Otherwise, ktimersoftd may not be awakened when it has work to do.

so the problem is that we have two softirq threads and we only check
the state of the "normal" one even if we would have also the schedule
the second one. 
The approach looks good, applied.

> [   84.087571] NOHZ: local_softirq_pending 02
> [   84.087593] NOHZ: local_softirq_pending 02
> [   84.087598] NOHZ: local_softirq_pending 02
> [   84.087904] NOHZ: local_softirq_pending 02
> [   84.088526] NOHZ: local_softirq_pending 02
> [   84.088899] NOHZ: local_softirq_pending 02
> [   84.089463] NOHZ: local_softirq_pending 02
> [  115.013470] NOHZ: local_softirq_pending 02
> [  115.013601] NOHZ: local_softirq_pending 02
> [  115.013709] NOHZ: local_softirq_pending 02
> 
> Signed-off-by: Mike Galbraith <efault@....de>

Sebastian