linux-kernel - Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484934914.12563.4.camel@perches.com>
Date:   Fri, 20 Jan 2017 09:55:14 -0800
From:   Joe Perches <joe@...ches.com>
To:     Chaitra P B <chaitra.basappa@...adcom.com>,
        JBottomley@...allels.com, jejb@...nel.org, hch@...radead.org
Cc:     martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        Sathya.Prakash@...adcom.com, kashyap.desai@...adcom.com,
        krishnaraddi.mankani@...adcom.com, linux-kernel@...r.kernel.org,
        suganath-prabu.subramani@...adcom.com, sreekanth.reddy@...adcom.com
Subject: Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at
 a degraded speed.

On Fri, 2017-01-20 at 20:12 +0530, Chaitra P B wrote:
> Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED
> when a cable is present and is running at a degraded speed
> (below the SAS3 12 Gb/s rate). Prints added
> to inform the user that the cable is not running at
> optimal speed.
[]
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
[]
> @@ -8028,15 +8028,23 @@ mpt3sas_scsih_event_callback(struct MPT3SAS_ADAPTER *ioc, u8 msix_index,
>  	case MPI2_EVENT_ACTIVE_CABLE_EXCEPTION:
>  		ActiveCableEventData =
>  		    (Mpi26EventDataActiveCableExcept_t *) mpi_reply->EventData;
> -		if (ActiveCableEventData->ReasonCode ==
> -				MPI26_EVENT_ACTIVE_CABLE_INSUFFICIENT_POWER) {
> -			pr_info(MPT3SAS_FMT "Currently an active cable with ReceptacleID %d",
> +		switch (ActiveCableEventData->ReasonCode) {
> +		case MPI26_EVENT_ACTIVE_CABLE_INSUFFICIENT_POWER:
> +			pr_info(MPT3SAS_FMT "Currently an active cable with ReceptacleID %d\n",
>  			    ioc->name, ActiveCableEventData->ReceptacleID);
> -			pr_info("cannot be powered and devices connected to this active cable");
> -			pr_info("will not be seen. This active cable");
> -			pr_info("requires %d mW of power",
> +			pr_info(" cannot be powered and devices connected to\n");
> +			pr_info(" this active cable will not be seen. This\n");
> +			pr_info(" cable requires %d mW of power\n",

Can you please use more intelligible logging
where sentences are not broken across multiple
lines of output?  Something like:

			pr_notice(MPT3SAS_FMT "Receptacle ID %d: This active cable requires %d mW of power\n",
				  ioc->name, ActiveCableEventData->ReceptacleID,
				  ActiveCableEventData->ActiveCablePowerRequirement);
			pr_notice(MPT3SAS_FMT "Receptacle ID %d: Devices connected to this active cable will not be seen\n",
				  ioc->name, ActiveCableEventData->ReceptacleID);

I believe MPT3SAS_FMT is unnecessary obfuscation and
it should just be replaced by "%s: " everywhere.