linux-kernel - Re: [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16029f0d74037f0c8023a0d562593556@codeaurora.org>
Date:   Fri, 20 Jan 2017 12:10:00 -0800
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Subject: Re: [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource

On 2017-01-19 02:47, Bjorn Andersson wrote:
> Upon failing to acquire regulator supplies the qcom-ufs driver calls
> kfree() on the devm allocated memory used to store the name of the
> regulator, leading to devres corruption.
> 
> Rather than switching to using the appropriate free function the patch
> acknowledge the fact that "name" is always a constant string and we
> don't actually need to create a local copy of it, but rather just
> reference the constant string.
> 
> Cc: Subhash Jadavani <subhashj@...eaurora.org>
> Cc: Vivek Gautam <vivek.gautam@...eaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  drivers/phy/phy-qcom-ufs.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index c69568b8543d..4d7f3c018223 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -217,12 +217,7 @@ static int __ufs_qcom_phy_init_vreg(struct device 
> *dev,
> 
>  	char prop_name[MAX_PROP_NAME];
> 
> -	vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);
> -	if (!vreg->name) {
> -		err = -ENOMEM;
> -		goto out;
> -	}
> -
> +	vreg->name = name;
>  	vreg->reg = devm_regulator_get(dev, name);
>  	if (IS_ERR(vreg->reg)) {
>  		err = PTR_ERR(vreg->reg);
> @@ -265,8 +260,6 @@ static int __ufs_qcom_phy_init_vreg(struct device 
> *dev,
>  	}
> 
>  out:
> -	if (err)
> -		kfree(vreg->name);
>  	return err;
>  }

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project