linux-kernel - Re: [PATCH 1/2] random: use chacha20 for get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170121001509.fj23eunnkaqj7yce@thunk.org>
Date:   Fri, 20 Jan 2017 19:15:09 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH 1/2] random: use chacha20 for get_random_int/long

On Fri, Jan 20, 2017 at 04:47:42PM +0100, Jason A. Donenfeld wrote:
> 
> What do you mean? Nothing is wasted right now. The u64 function only
> gets u64s from a dedicated u64 array. The u32 function only gets u32s
> from a dedicated u32 array. There are separate batched entropy arrays
> for each function.

But there is a shared pointer, which is used both for the dedicated
u32 array and the dedicated u64 array.  So when you increment the
pointer for the get_random_u32, the corresponding entry in the u64
array is wasted, no?

						- Ted