linux-kernel - Re: [PATCH] iio: accel: st_accel: add !SENSORS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81fbb625-4626-d204-3ade-6640f01ad506@kernel.org>
Date:   Sat, 21 Jan 2017 12:34:34 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: accel: st_accel: add !SENSORS_LIS3LV02D depedency

On 20/01/17 16:25, Arnd Bergmann wrote:
> warning: (IIO_ST_ACCEL_3AXIS) selects IIO_ST_ACCEL_SPI_3AXIS which has unmet direct dependencies (IIO && !SENSORS_LIS3_SPI && IIO_ST_ACCEL_3AXIS && IIO_ST_SENSORS_SPI)
> 
> Fixes: 762227721fe6 ("iio: accel: st_accel: handle deprecated bindings")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
At least at first glance, this is a different approach to fixing the issue
from the one Linus took.  I think that one has already been picked up
by Greg (or will be shortly).  Linus, please confirm this is the same issue.

thanks,

Jonathan
> ---
>  drivers/iio/accel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index ea295fe0f561..590ba8835fdc 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -120,6 +120,7 @@ config HID_SENSOR_ACCEL_3D
>  config IIO_ST_ACCEL_3AXIS
>  	tristate "STMicroelectronics accelerometers 3-Axis Driver"
>  	depends on (I2C || SPI_MASTER) && SYSFS
> +	depends on !SENSORS_LIS3LV02D
>  	select IIO_ST_SENSORS_CORE
>  	select IIO_ST_ACCEL_I2C_3AXIS if (I2C)
>  	select IIO_ST_ACCEL_SPI_3AXIS if (SPI_MASTER)
>