linux-kernel - Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485006980.2133.279.camel@linux.intel.com>
Date:   Sat, 21 Jan 2017 15:56:20 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Stephen Boyd <sboyd@...eaurora.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     linux-clk@...r.kernel.org, x86@...nel.org,
        platform-driver-x86@...r.kernel.org,
        Darren Hart <dvhart@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        alsa-devel@...a-project.org, Irina Tirdea <irina.tirdea@...el.com>,
        Michael Turquette <mturquette@...libre.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>, Len Brown <lenb@...nel.org>,
        Vinod Koul <vinod.koul@...el.com>
Subject: Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks

On Fri, 2017-01-20 at 15:58 -0800, Stephen Boyd wrote:
> On 01/17, Pierre-Louis Bossart wrote:
> > 

> > +static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32
> > val)
> > +{
> > +	u32 tmp;
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&clk->lock, flags);
> > +
> > +	tmp = clk_readl(clk->reg);
> 
> Do you need to use clk_readl? I'd prefer we deleted that
> function/macro because it's just confusing.

Good to know.

>  Please don't use it
> unless you need it for some reason.

It was my suggestion, I didn't know that the mentioned API is kinda
deprecated.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy